Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: Use management endpoint for scope by default #1637

Merged
merged 2 commits into from
Dec 13, 2023
Merged

auth: Use management endpoint for scope by default #1637

merged 2 commits into from
Dec 13, 2023

Conversation

alexweininger
Copy link
Member

@alexweininger alexweininger requested a review from a team as a code owner November 30, 2023 20:49
@alexweininger
Copy link
Member Author

I'm going to have CTI test Azure Resources with this update before merging this and releasing.

nturinski
nturinski approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leave a comment about how we've tested that resourceManagerEndpointUrl's audience token seems to a subset of managementEndpointUrl? Otherwise people might get really confused as to why we use managementEndpointUrl here, but everywhere else we create the clients, we use resourceManagerEndpointUrl as the endpoint.

@alexweininger
Copy link
Member Author

Maybe leave a comment about how we've tested that resourceManagerEndpointUrl's audience token seems to a subset of managementEndpointUrl? Otherwise people might get really confused as to why we use managementEndpointUrl here, but everywhere else we create the clients, we use resourceManagerEndpointUrl as the endpoint.

I want to add a comment but I want it to be accurate so we should consult someone who actually knows.

@bwateratmsft
Copy link
Contributor

Maybe leave a comment about how we've tested that resourceManagerEndpointUrl's audience token seems to a subset of managementEndpointUrl? Otherwise people might get really confused as to why we use managementEndpointUrl here, but everywhere else we create the clients, we use resourceManagerEndpointUrl as the endpoint.

I want to add a comment but I want it to be accurate so we should consult someone who actually knows.

inb4 comment: We have no idea why this works but it does so don't change it

@nturinski
Copy link
Member

image
image

🤷

@alexweininger alexweininger merged commit dfd7aba into main Dec 13, 2023
4 checks passed
@alexweininger alexweininger deleted the alex/pink-sturgeon branch December 13, 2023 18:50
@alexweininger alexweininger mentioned this pull request Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwateratmsft bwateratmsft bwateratmsft approved these changes

@nturinski nturinski nturinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to deploy the JavaScript project to the Node.js function app with Azure China account
3 participants
@alexweininger @bwateratmsft @nturinski